search

swri-robotics / mapviz

Modular ROS visualization tool for 2D data.
BSD 3-Clause "New" or "Revised" License
370 stars 144 forks source link

Fix bing tiles not rendering #799

Closed agyoungs closed 7 months ago

agyoungs commented 7 months ago

There's a race condition causing bing map tiles to not work properly. This issue is probably only noticed intermittently or in some workflows but not others.

If the transform from wgs84 to map is ready before the bing server reply has been received, no bing tiles will be displayed. If you have mapviz open before starting up the ros service, you won't see this issue, but if you start mapviz (or change to the bing tile source after the transform is ready, you're unlikely to see any tiles displayed. You might get lucky if you're using launch files and mapviz gets the bing reply just in time before the transform is ready.

agyoungs commented 7 months ago

It appears that is_ready_ flag is only set to true in the bing map tile source, so my assumption is that the other sources are ready immediately (since the flag initializes to true), although I didn't test the other sources.

danthony06 commented 7 months ago

Thanks @agyoungs