Closed DangitBen closed 2 months ago
The new topic QoS selector provides options for many QoS settings.
In (at least) the marker plugin, the subscribers created use rclcpp::QoSInitialization::from_rmw to construct a rclcpp::QoS. But that does not respect all of the members of the provided qos. https://github.com/swri-robotics/mapviz/blob/ros2-devel/mapviz_plugins/src/marker_plugin.cpp#L140 and https://github.com/swri-robotics/mapviz/blob/ros2-devel/mapviz_plugins/src/marker_plugin.cpp#L147
rclcpp::QoSInitialization::from_rmw
rclcpp::QoS
According the documentation and source of the rclcpp::QoSInitialization::from_rmw the returned QoS only uses the provided depth and history.
The new topic QoS selector provides options for many QoS settings.
In (at least) the marker plugin, the subscribers created use
rclcpp::QoSInitialization::from_rmwto construct arclcpp::QoS. But that does not respect all of the members of the provided qos. https://github.com/swri-robotics/mapviz/blob/ros2-devel/mapviz_plugins/src/marker_plugin.cpp#L140 and https://github.com/swri-robotics/mapviz/blob/ros2-devel/mapviz_plugins/src/marker_plugin.cpp#L147According the documentation and source of the
rclcpp::QoSInitialization::from_rmwthe returned QoS only uses the provided depth and history.