search

swri-robotics / marti_common

Common utility functions for MARTI
BSD 3-Clause "New" or "Revised" License
54 stars 63 forks source link

Add support for Humble #685

Closed shrijitsingh99 closed 2 years ago

shrijitsingh99 commented 2 years ago

Fixes dependencies and build issues while building for Humble Updates geos library with and uses their new API Fixes CMake issues

danthony06 commented 2 years ago

Looks really good at first glance, thank you. Let me see if this will work with Foxy and Galactic, or if I need to permanently branch them.

On Sat, Sep 17, 2022, 10:37 AM Shrijit Singh @.***> wrote:

Fixes dependencies and build issues while building for Humble Updates geos library with and uses their new API Fixes CMake issues

You can view, comment on, or merge this pull request online at:

https://github.com/swri-robotics/marti_common/pull/685 Commit Summary

File Changes

(16 files https://github.com/swri-robotics/marti_common/pull/685/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/swri-robotics/marti_common/pull/685, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBZWHF5DDBTVCYPISAFPFLV6XQTBANCNFSM6AAAAAAQPBTS7E . You are receiving this because you are subscribed to this thread.Message ID: @.***>

danthony06 commented 2 years ago

@shrijitsingh99 did you want to make these changes? Otherwise I can fork your changes and make them.

danthony06 commented 2 years ago

@pjreed I've started working on the C API switch here: https://github.com/danthony06/marti_common/tree/c_api_switch.

danthony06 commented 2 years ago

@pjreed My C API branch is now building and passing tests, but I'm not entirely happy with the implementation and how it's handling GEOS contexts.

danthony06 commented 2 years ago

I've started working on bringing these changes into a branch here: https://github.com/danthony06/marti_common/tree/humble_support

shrijitsingh99 commented 2 years ago

@danthony06 Thanks for taking over this. I have not have had the cycles to take this further, sorry about that. This is still a dependency for my project, and have more time now. Let me know if there is anyway I can help out.

danthony06 commented 2 years ago

@shrijitsingh99 Thank you for all your help on this. I've based a new PR on this over here: https://github.com/swri-robotics/marti_common/pull/691. I'm closing this PR in favor of the other one.