swri-robotics / marti_common

Common utility functions for MARTI
BSD 3-Clause "New" or "Revised" License
53 stars 62 forks source link

Make ROS 2 GetTransform() Timeout Consistent with ROS 1 Timeout #694

Closed vknisley-swri closed 1 year ago

vknisley-swri commented 1 year ago

In ROS 1, a timeout of 0.1 seconds is used in one of swri_transform_utils' GetTransform() calls. This was changed to a timeout of 0 in ROS 2. This PR would revert the timeout back to what it was in ROS 1.

This change should be tested more before it is merged in. Also, I noticed that this timeout was originally 0.1 seconds in ROS 2 as well, so please let me know if this timeout should remain 0.

tiffanyec commented 1 year ago

Has been tested and appears functional