swri-robotics / marti_common

Common utility functions for MARTI
BSD 3-Clause "New" or "Revised" License
54 stars 63 forks source link

Add publisher and subscription options to ROS 2 swri_roscpp pub / sub constructors #714

Closed vknisley-swri closed 1 year ago

vknisley-swri commented 1 year ago

With this change, someone using swri_roscpp's publishers or subscribers will be able to put subscriptions into a non-default callback group or turn on intraprocess communications at the pub/sub level, along with some other configuration features.

I currently have the SubscriptionOptions as the last argument, but if we think that argument is more likely to be used / required than the transport hints / QoS, then I can flip them.