search

swri-robotics / marti_common

Common utility functions for MARTI
BSD 3-Clause "New" or "Revised" License
53 stars 62 forks source link

Increase minimum CMake version to 3.16 #732

Closed daniel-dsouza closed 3 months ago

daniel-dsouza commented 3 months ago

When building with newer (CMake 3.28), the following warning will appear.

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

This PR increases minimum CMake version to 3.16 to satisfy the compatibility check in newer CMake versions.

Note that Ubuntu focal (ROS Noetic) packages CMake 3.16.3, so this will be incompatible with the EOL ROS Melodic.

danthony06 commented 3 months ago

Thanks. I made a branch called melodic-eol before merging this since it is a breaking change.