search

swri-robotics / marti_common

Common utility functions for MARTI
BSD 3-Clause "New" or "Revised" License
53 stars 62 forks source link

Breaking change in latest commit #738

Closed RobertBlakeAnderson closed 1 month ago

RobertBlakeAnderson commented 3 months ago

On the master branch:

The latest commit causes build errors for us. This is caused by the change of #include <proj_api.h> to #include <proj.h>. The old name is what we have in /usr/include on our machines.

danthony06 commented 3 months ago

@RobertBlakeAnderson Unfortunately, I'm in a bit of a catch-22 on this. Before I made the breaking change, I made a tag called melodic-eol because I knew it would break with older versions of PROJ. The rationale for making it is we have other users that are pushing forward with newer versions of PROJ and the current implementation works with Noetic, which is the only non-EOL ROS 1 distribution at this point. Unfortunately, the API changes with the new version of PROJ are not easy to work around.

Since I haven't bloomed these changes, I assume you're building from source? If so, can you keep using the melodic-eol branch, or do you really want to keep using our head changes?