swri_transform_util's origin_manager.py uses deprecated QoS values

swri-robotics / marti_common

Common utility functions for MARTI

BSD 3-Clause "New" or "Revised" License

54 stars 63 forks source link

swri_transform_util's origin_manager.py uses deprecated QoS values #748

Closed DangitBen closed 1 month ago

DangitBen commented 1 month ago

https://github.com/swri-robotics/marti_common/blob/ros2-devel/swri_transform_util/swri_transform_util/origin_manager.py#L130

Running the origin_manager.py through initialize_origin.py on 22.04 gives the following output:

/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/qos.py:307: UserWarning: DurabilityPolicy.RMW_QOS_POLICY_DURABILITY_TRANSIENT_LOCAL is deprecated. Use DurabilityPolicy.TRANSIENT_LOCAL instead.

rjb0026 commented 1 month ago

@DangitBen are we good to close this out now that #752 is merged?

danthony06 commented 1 month ago

Should be.

DangitBen commented 1 month ago

Yep! Thanks!