search

swri-robotics / novatel_gps_driver

ROS driver for NovAtel GPS / GNSS receivers
BSD 3-Clause "New" or "Revised" License
171 stars 130 forks source link

Improve Default Behavior #89

Closed matt-attack closed 4 years ago

matt-attack commented 4 years ago

Currently with default settings the gps_common/GPSFix message never gets its track or speed filled out and the GPSFix is published whether or not it is valid. This logs the bestvel by default and removes gpsrmc from the default logs. It also adds a parameter to disable publishing invalid gpsfixes.

matt-attack commented 4 years ago

@pjreed the CI seems to have kicked the bucket and I'm not sure how to re-run it.

The build actually succeeded but it didn't make it to this page. https://travis-ci.org/github/swri-robotics/novatel_gps_driver/builds/696632167

matt-attack commented 4 years ago

This still needs to be tested again before its ready to merge. I made a few changes since the last time I tested it.

pjreed commented 4 years ago

@pjreed the CI seems to have kicked the bucket and I'm not sure how to re-run it.

The build actually succeeded but it didn't make it to this page. https://travis-ci.org/github/swri-robotics/novatel_gps_driver/builds/696632167

I just updated the repo to use GitHub Actions instead of Travis, so try merging master into this and pushing it to see if it re-runs it now.

pjreed commented 4 years ago

Looks good to me now, just let me know if you've tested it and it works for you.

matt-attack commented 4 years ago

@pjreed tested on the vehicle and works as expected now

matt-attack commented 4 years ago

@pjreed should be good to go now

pjreed commented 4 years ago

Oops, I actually thought I had merged this already.

matt-attack commented 4 years ago

Thanks!