Code Review by Team 5

[pbzweihander]

Code Review by Team 5

Repository

• Please configure CI properly
• Coverage report tool such as coveralls or codecov is recommended

Frontend

Lint Error

ERROR: /home/thomas/files/swpp18-team1/front/src/app/access/access.component.ts[17, 17]: Type string trivially inferred from a string literal, remove type annotation
ERROR: /home/thomas/files/swpp18-team1/front/src/app/access/access.component.ts[17, 26]: " should be '
ERROR: /home/thomas/files/swpp18-team1/front/src/app/access/access.component.ts[29, 40]: Missing semicolon

...

ERROR: /home/thomas/files/swpp18-team1/front/src/service/user.service.ts[95, 34]: " should be '
ERROR: /home/thomas/files/swpp18-team1/front/src/service/user.service.ts[100, 34]: " should be '
ERROR: /home/thomas/files/swpp18-team1/front/src/service/user.service.ts[120, 6]: Missing semicolon

Backend

Security

@csrf_exempt
def channel(request):
    ...

Please prevent CSRF attacks.

Lint Error

back/routing.py:11:13: E123 closing bracket does not match indentation of opening bracket's line
back/routing.py:12:9: E123 closing bracket does not match indentation of opening bracket's line
back/routing.py:13:5: E123 closing bracket does not match indentation of opening bracket's line

...

chat/consumers.py:63:121: E501 line too long (123 > 120 characters)
chat/consumers.py:78:5: E303 too many blank lines (2)
chat/consumers.py:79:5: E301 expected 1 blank line, found 0

Performance

Link

username = json.loads(body)['username']
password = json.loads(body)['password']

json.loads called twice with the same argument.