About linter rules - Githubissues

We disabled many rules in eslint so far. Some were for convenience, and some others were... because I just didn't know what it means. I think we have to write down rules we deactivated, and think about if we shouldn't deactivate some of them or be careful about deactivated rules.

Please update this continuously when new rules are disabled.

"react/jsx-filename-extension":[1,{"extensions":[".js",".jsx"]}],

originally only .jsx files are allowed. This makes .js files allowed too.

"react/prop-types": 0,

I don't remember(and understand search result...) well... But in my memory, this rule didn't allow coding style like in practice.

"no-console": 0,

This rule didn't allow console.log(). Disabled this for debugging.

"no-param-reassign": 0,

This rule made an error in serviceWorker.js. This file is out of our control, so I disabled this.

"import/no-extraneous-dependencies": ["error", {"devDependencies": true}],

This rule made an error in setupTest.js. I thought this is also out of our control, but maybe we can modify this because this file is very short.

"no-unused-vars": 0,

This rule doesn't allow the unused variables. Because this is very inconvenient for coding, I disabled this.

"import/prefer-default-export": 0,

This rule doesn't allow "export const var=~~~". But this was the coding style in practice, so I disabled this.

"react/prefer-stateless-function": 0,

Honestly, I don't understand about this.

"import/no-named-as-default": 0,

This rule is something about importing and exporting names... I believe this isn't very important.

"import/no-named-as-default-member": 0,

Similar to the above one.

"no-underscore-dangle": 0,

This rule doesn't allow signin_(). But this is a coding style in practice.

"react/state-in-constructor": 0,

This rule doesn't allow state={...} in class. But this is a coding style in practice.

"react/destructuring-assignment": 0,

This rule enforces destructuring assignment. But I don't understand this really...

"react/no-unused-state": 0,

This rule doesn't allow unused states. Inconvenient for coding.

"jsx-a11y/click-events-have-key-events": 0,

This rule enforces to have keyboard listener(?) for elements with click handler... I don't understand much.

"jsx-a11y/no-static-element-interactions": 0,

Not sure what this means...

"no-alert": 0,

This rule doesn't allow alert(). But we need this. right?

"vars-on-top": 0,

This rule enforces vars to be on the top. Inconvenient for coding.

"no-var": 0,

This rule doesn't allow var. well...

"no-plusplus": 0,

This rule doesn't allow ++. But isn't it good?

"block-scoped-var": 0,

This rule doesn't allow using var outside of its block scope. This is actually right... but inconvenient for coding.

"radix": ["error", "as-needed"],

This rule enforces to write radix for parseInt(). "as-needed" option allows radix 10 not written.

"no-nested-ternary": 0,

This rule doesn't allow nested usage of the ternary operators. Inconvenient for coding.

"react/button-has-type": 0,

This rule enforces to write type="button" at button element. Inconvenient for coding.

"jsx-a11y/label-has-associated-control": 0,

This rule enforces label element should have control...? I don't understand much.

"max-len": 0,

This rule enforces max length of a line to be less than 100, even for comment. Inconvenient for coding.

"global-require": 0,

This rule is about require() of image in images/index.js. I don't know much about this for now.

swsnu / swpp2020-team2

About linter rules #43