swsnu / swpp2021-team4

🚂 Tripick : Pick your trip! 🛤
2 stars 1 forks source link

feat/ change base routes in CreateEditPostPage #208

Closed yeppin closed 2 years ago

yeppin commented 2 years ago

help wanted

  1. When there are places with same origin & destination on different day, path calculation does not change automatically unless the user select its transportation once again
  2. Map markers become blank when the user add places from 'cart' to 'my routes' => fixed
  3. Select option warning occurs on CreateEditHeader 스크린샷 2021-12-12 오후 10 25 17
kjw7953 commented 2 years ago

When there are places with same origin & destination on different day, path calculation does not change automatically unless the user select its transportation once again

So, you mean when a user changes the transportation for the first time, it doesn't change. Right?

I will elaborate further with the example below original info Day 1: place A -> place B (by car 35 m) Day 2: place A -> place B (by bus 40 m)

when user clicks Day2 tap from Day1, it seems like Day 1: place A -> place B (by car 35 m) Day 2: place A -> place B (by bus 35 m) // not being changed from previous 'car' path time

Even though Day2 route is different from Day1, it does not automatically calculate returned time unless the user selects 'bus' option again

I figured out it relates to codes in Path.tsx line 44 ~ 56, which is useEffect function with setPathTime. The second parameter, dependencies, should be fixed in order to recalculate the path. But I still couldn't find any answer.

-> Ah, I got your point! Did you fix it? I will have a look if you did not fix it yet.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

29.5% 29.5% Coverage
0.0% 0.0% Duplication