search

swsnu / swppspr2015

Repository for discussing common issues that are not project-specific, SNU SWPP Spring 2015
https://sites.google.com/site/snuswppspr2015/
0 stars 0 forks source link

Question about where to send killed tasks #24

Open sunghwanl opened 9 years ago

sunghwanl commented 9 years ago

Regarding killing tasks in FailureHandler, I wonder where I have to add the task after killing.

Since there is no FailedTasks ArrayList in Scheduler, it seems both possible to add the killed tasks to FinishedTasks or CanceledTasks.

jsjason commented 9 years ago

Sorry for the late reply. There's no restriction on modifying the files. Feel free to rewrite the Scheduler class, if you need to.

sunghwanl commented 9 years ago

I just added killed tasks to CanceledTasks. Is it ok?

jsjason commented 9 years ago

Of course it's okay. It's okay to do anything you want with the files to achieve the requirements of the assignment, given that your work satisfies the grading criteria.

sunghwanl commented 9 years ago

Thanks for your answer.

bgchun commented 9 years ago

There is no correct or wrong answer if your design is reasonable. Of course, there is a better or worse solution.

Describe your design briefly in README so that we don't miss your thought process.

On Mon, Jun 8, 2015 at 1:38 PM, Sung-HwanLee notifications@github.com wrote:

Thanks for your answer.

— Reply to this email directly or view it on GitHub https://github.com/swsnu/discussionswppspr2015/issues/24#issuecomment-109860259 .

Byung-Gon Chun