search

swttt / com.swttt.homekit

Homekit for Homey
https://apps.athom.com/app/com.swttt.homekit
GNU Affero General Public License v3.0
35 stars 20 forks source link

Option to enable devices instead of removing #134

Open mbnn opened 5 years ago

mbnn commented 5 years ago

Hello,

Right now you can go to settings and manually 'Remove' a device from Homekit through your app. Would it be possible to do the opposite? So an option to include devices selected only? :)

The reason Im asking this is because I have a lot of devices that are also directly connected to Homekit (like Philips Hue, Netatmo and some others). Everytime there is an update or reboot of Homey I have to manually remove the devices again, looks like it does not save what is 'removed'.

Thanks.

robertklep commented 5 years ago

So the main problem that you're having is that your settings aren't being saved correctly ;)

Do you use automations/scenes in HomeKit, or assign devices to particular rooms? If so, are those settings also lost after an update or reboot of Homey?

mbnn commented 5 years ago

Haha, indeed you are right :) I assign each device to the right room in Homekit (which works, except for devices that are 'excluded in the homeykit app).

robertklep commented 5 years ago

I think I know why the settings aren't saved correctly. I'll try to work out a fix.

jahnkenneth commented 5 years ago

I’m also having this issue. Any ETA on the fix?

robertklep commented 5 years ago

Hopefully within the next few days, at least in a beta release.

jahnkenneth commented 5 years ago

Looking forward to it :-D

robertklep commented 5 years ago

3.0.7 is published as a beta, please try and see if it works better for you.

FrankRinkens commented 5 years ago

@robertklep this version is absolutely working. Only thing I would suggest is doing it the other way around, meaning first install everything isn't added. User should add per device by himself. I use Homeykit so my wife can use (some) devices in a easy way. In the way you implemented it's a lot of work to setup, also a disable all option is missing in this setup. Setting it up the other way around would be better I think.

robertklep commented 5 years ago

@FrankRinkens I think that most users will be using the app the other way around, where they want most of their devices exposed to iOS. By using "not exposed" as a default, I think a lot of users will be confused when they add Homeykit and don't see anything appearing on their iOS devices.

Enable/disable All does sound like a good option, though!

FrankRinkens commented 5 years ago

ok ;)

mbnn commented 5 years ago

Have to agree with @FrankRinkens on this one though, by default it will show all devices that already have homekit by itself aswell. So it will show Philips Hue stuff twice in Homekit, same with Netatmo and other things :) But an option to enable/disable all at once is good :P