swttt / com.swttt.homekit

Homekit for Homey
https://apps.athom.com/app/com.swttt.homekit
GNU Affero General Public License v3.0
35 stars 20 forks source link

(Slide) curtains not showing correct status #202

Open meijerpeter opened 3 years ago

meijerpeter commented 3 years ago

Hi,

I have added the Siide curtains to the Homey and enabled them via Homekit in my Home app. The commands are getting through correctly, but the status of the curtains in the Home app is always "closed". In the Homey app I have the correct status.

For example, if I tell Home to set the curtains to 50% they are at 50%, but in the Home app the status is "closed". In Homey the 50% is shown.

All apps are updated to their latest version (Homey 7.1.3, Homeykit v3.0.16).

Let me know if you need any diagnostic data.

Thanks for your amazing work!!

robertklep commented 3 years ago

The app probably uses multiple capabilities that are conflicting (at least in how Homeykit interprets them).

You can find the device and the current state of its capabilities here: https://tools.developer.homey.app/tools/devices

I'm interested in the values of the capabilities when you get an incorrect status.

meijerpeter commented 3 years ago

Completely closed:

Screenshot 2021-09-25 at 16 10 46

Completely open:

Screenshot 2021-09-25 at 16 12 16

Set to 56%:

Screenshot 2021-09-25 at 16 13 10
robertklep commented 3 years ago

I'm not sure how Home decides if a curtain is closed or not. From what I can see, there's nothing in Homeykit that sets that state.

meijerpeter commented 3 years ago

Update: the closed curtain is displaying 8% open. The value in Homey is 0.08. The other is closed and has value o.97. I think Slide has their numbers inverted…. Hassio had the same problem, see their option at the bottom: https://www.home-assistant.io/integrations/slide/

I will ask the developers of the Slide plugin if they can change this behaviour, or is this something you can change?

On 25 Sep 2021, at 14:58, Robert Klep @.***> wrote:

The app probably uses multiple capabilities that are conflicting (at least in how Homeykit interprets them).

You can find the device and the current state of its capabilities here: https://tools.developer.homey.app/tools/devices https://tools.developer.homey.app/tools/devices I'm interested in the values of the capabilities when you get an incorrect status.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swttt/com.swttt.homekit/issues/202#issuecomment-927117722, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVZYL2VPIELLQG7OGR3MILUDXBPBANCNFSM5EXOAMMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

robertklep commented 3 years ago

Both in HomeKit and in Homey, 0 should mean "fully closed" and 100 (or "1" in Homey) should mean "fully open". That's what Homeykit assumes as well.

What might be an issue though is that the Homey values don't to all the way to 0 and 1. I can imagine that Home might consider any value not 1 to be "closed" (or at least partially closed).

meijerpeter commented 3 years ago

I agree, I don’t see whole numbers. You might be helping out to round the open and close states when the value is “almost” 0 or 1, e.g. 0.97 can be rounded to open?

On 25 Sep 2021, at 17:41, Robert Klep @.***> wrote:

Both in HomeKit and in Homey, 0 should mean "fully closed" and 100 (or "1" in Homey) should mean "fully open". That's what Homeykit assumes as well.

What might be an issue though is that the Homey values don't to all the way to 0 and 1. I can imagine that Home might consider any value not 1 to be "closed" (or at least partially closed).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swttt/com.swttt.homekit/issues/202#issuecomment-927138760, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVZYL3Y6Y7IGFQWQNUT2WLUDXUTBANCNFSM5EXOAMMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

robertklep commented 3 years ago

Rounding would work in your situation, but I have no idea if that would break things for other people. So ideally, the issue should be fixed in the app.

meijerpeter commented 3 years ago

Agreed!

On 25 Sep 2021, at 17:47, Robert Klep @.***> wrote:

Rounding would work in your situation, but I have no idea if that would break things for other people. So ideally, the issue should be fixed in the app.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swttt/com.swttt.homekit/issues/202#issuecomment-927139540, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVZYL2VDYJH4PPEXFYZSQ3UDXVKJANCNFSM5EXOAMMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.