swuff-star
commented
2 years ago Good report! Well written + documented. I'd guess this is a cross-compat issue with another mod. Would you mind posting a Log, as well as a mod list? Thank you.
Closed Elemental03 closed 2 years ago
swuff-star
commented
2 years ago Good report! Well written + documented. I'd guess this is a cross-compat issue with another mod. Would you mind posting a Log, as well as a mod list? Thank you.
Elemental03
commented
2 years ago Good report! Well written + documented. I'd guess this is a cross-compat issue with another mod. Would you mind posting a Log, as well as a mod list? Thank you.
Of course! Would the log be the one located in BepInEx called "LogOutput"? Also, as for posting a mod list would you want the profile exported as code/file, a screenshot, or for me to just list them out in text?
SOMSTATE
commented
2 years ago Had a similar issue, deleting the .config file fixed this for me.
Elemental03
commented
2 years ago Had a similar issue, deleting the .config file fixed this for me.
Really? The mod still works even without it?
SOMSTATE
commented
2 years ago Really? The mod still works even without it?
Yes, it rebuilds the config once you start the game after deleting it.
Nebby1999
commented
2 years ago What concenrs me the most is the item in your inventory on this image.
That icon is from unfinished items in the base ror2 game, such as AACannon and used for generally content that has null icons, could you please tell me what item is that? press tab and hover over it, it'll most likely say something along the lines of ITEM_THING_NAME
Elemental03
commented
2 years ago What concenrs me the most is the item in your inventory on this image.
It says ITEM_MONSOONHELPER_NAME and there's another one called ITEM_DRIZZLEHELPER_NAME, it only appears on Drizzle, Monsoon, and gives me two stacks of the Monsoon one on Typhoon, so I guess those are the difficulty modifiers, seeing as Drizzle boosts your stats, while Monsoon and Typhoon debuff you. Only a guess though, I am literally a script kiddie learning do while loops, so I'm pretty dumb when it comes to debugging and whatnot
Nebby1999
commented
2 years ago What concenrs me the most is the item in your inventory on this image.
It says ITEM_MONSOONHELPER_NAME and there's another one called ITEM_DRIZZLEHELPER_NAME, it only appears on Drizzle, Monsoon, and gives me two stacks of the Monsoon one on Typhoon, so I guess those are the difficulty modifiers, seeing as Drizzle boosts your stats, while Monsoon and Typhoon debuff you. Only a guess though, I am literally a script kiddie learning do while loops, so I'm pretty dumb when it comes to debugging and whatnot
how come you have those items, theyre hidden by default and never appear in the inventory UI.
Elemental03
commented
2 years ago how come you have those items, theyre hidden by default and never appear in the inventory UI.
It could be a UI mod that shows the stats of every item or something along the lines of that, I'm about to start playing around with settings and mods until making it go away
Elemental03
commented
2 years ago how come you have those items, theyre hidden by default and never appear in the inventory UI.
Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
Nebby1999
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
Elemental03
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
selfKaiHarness
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
Did you disable the Blighted elites in the Lost In Transit config? If so, this is likely the issue that is causing the stat scaling bug as far as I know of.
Elemental03
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
Did you disable the Blighted elites in the Lost In Transit config? If so, this is likely the issue that is causing the stat scaling bug as far as I know of.
Yeah I found out that was the case (I updated the post when I found out), enabling them fixes the issue, but I'd like to play without them; don't really like the mechanic of enemies basically becoming imps and just dodging every attack, not really fun on artifact of honor. Plus, the particles destroy my potato pc
selfKaiHarness
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
Did you disable the Blighted elites in the Lost In Transit config? If so, this is likely the issue that is causing the stat scaling bug as far as I know of.
Yeah I found out that was the case (I updated the post when I found out), enabling them fixes the issue, but I'd like to play without them; don't really like the mechanic of enemies basically becoming imps and just dodging every attack, not really fun on artifact of honor. Plus, the particles destroy my potato pc
I think blacklisting them is the only way to prevent them spawning as blighted elites, if you don't want any enemy you can add them to the blighted elite blacklist on the config for now until they fix this issue.
Elemental03
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
Did you disable the Blighted elites in the Lost In Transit config? If so, this is likely the issue that is causing the stat scaling bug as far as I know of.
Yeah I found out that was the case (I updated the post when I found out), enabling them fixes the issue, but I'd like to play without them; don't really like the mechanic of enemies basically becoming imps and just dodging every attack, not really fun on artifact of honor. Plus, the particles destroy my potato pc
I think blacklisting them is the only way to prevent them spawning as blighted elites, if you don't want any enemy you can add them to the blighted elite blacklist on the config for now until they fix this issue.
Is this done through LostInTransit's config?
selfKaiHarness
commented
2 years ago Might have gotten a world record for being the biggest idiot, I changed a config file for the "Better UI" mod and there was an option to show hidden items
that explains that at least, but i wouldnt be so sure if thats actually what was causing this issue, regardless, if you could try without better UI showing hidden items i'd be much obliged (better if its not even enabled, since we'll still be able to tell if there are stat errors due to the HP bar being numeric)
I tried with everything disabled except LostInTransit and still got the same results, I couldn't get a ss where you could read the values and see enabled/disabled mods, so I added a ss of the necessary mods being the only ones enabled to the main post
Did you disable the Blighted elites in the Lost In Transit config? If so, this is likely the issue that is causing the stat scaling bug as far as I know of.
Yeah I found out that was the case (I updated the post when I found out), enabling them fixes the issue, but I'd like to play without them; don't really like the mechanic of enemies basically becoming imps and just dodging every attack, not really fun on artifact of honor. Plus, the particles destroy my potato pc
I think blacklisting them is the only way to prevent them spawning as blighted elites, if you don't want any enemy you can add them to the blighted elite blacklist on the config for now until they fix this issue.
Is this done through LostInTransit's config?
Yes. It's through the Lost In Transit's config.
Elemental03
commented
2 years ago Yes. It's through the Lost In Transit's config.
How do you find the CharacterBody names?
selfKaiHarness
commented
2 years ago Yes. It's through the Lost In Transit's config.
How do you find the CharacterBody names?
Right in this Link: https://github.com/risk-of-thunder/R2Wiki/wiki/Resources-Paths
Nebby1999
commented
2 years ago Just for reference, this happens only when blighted elites are disabled, correct? because if so i think i know whats causing this issue.
my gut feeling tells me that, when blighted elites are disabled, the equipmentdef is never passed down to LIT's content pack, this causes the EquipmentDef for blighted elites to have an equipment index of -1.
The issue comes by, when the player starts and has no equipment, its equipment index is also -1, MSU's item manager adds an equipment's item behavior if the equipment index matches.
This is usually not a bad thing for elite equipments, since most of their behavior is stored in the buff itself instead, and as such, the equipmentBase has no method for adding an item behavior. but Blighted elites are an exception to this, since all their stat increases (such as HP, Damage & MoveSpeed) are tied to the equipment and not the buff.
Nebby1999
commented
2 years ago [Info : Unity Log] Does CommandoBody(Clone) (RoR2.CharacterBody) have [GiganticAmethyst (RoR2.EquipmentDef), LostInTransit.Equipments.GiganticAmethyst]? False [Info : Unity Log] Does CommandoBody(Clone) (RoR2.CharacterBody) have [AffixBlighted (RoR2.EquipmentDef), LostInTransit.Equipments.AffixBlighted]? True [Info : Unity Log] Does CommandoBody(Clone) (RoR2.CharacterBody) have [AffixFrenzied (RoR2.EquipmentDef), LostInTransit.Equipments.AffixFrenzied]? False [Info : Unity Log] Does CommandoBody(Clone) (RoR2.CharacterBody) have [AffixLeeching (RoR2.EquipmentDef), LostInTransit.Equipments.AffixLeeching]? False [Info : Unity Log] Does CommandoBody(Clone) (RoR2.CharacterBody) have [AffixVolatile (RoR2.EquipmentDef), LostInTransit.Equipments.AffixVolatile]? False
After doing some debug logging, its indeed what i'm describing, this is mainly an issue with MSU (prolly with how elite equipments are handled) so i'll have to fix it there and it should fix this issue
Nebby1999
commented
2 years ago I have no confirmed that this issue was caused by the MoonstormItemManager checking thru each elite equipment in the equipment dictionary, this included elite equipments that werent in the game (due to not being in the contentpack) and as such, caused these issues.
The fix itself is in MSU and not in LIT, as such, the next update of MSU should fix this issue.
Main Post
Not sure why, but the mod causes odd starting health and damage values. I've playtested with other mods with LostInTransit loaded, and then with only LostInTransit (+dependencies) loaded, and played across all difficulties (I thought difficulty affected health scaling but it was the same across all of them, even Typhoon). If I start a run with no artifacts, starting health is 770 with the base damage being 36. But if I start with the Artifact of Enigma specifically, my HP is 16 or 12 (depending on the character), and my base damage is 4. Screenshots below were taken to show each instance in which values were either modified or default.
Note: Disabling Blighted enemies in the config file is what causes the issue.
Side Note: the item in my inventory was a hidden item called ITEM_DRIZZLEHELPER_NAME and ITEM_MONSOONHELPER_NAME (shown by the BetterUI mod with config adjusted to show hidden items), which turned out to be difficulty modifiers i.e. Drizzle buffs and Monsoon/Typhoon debuffs
Partial Fix
As suggested by SOMSTATE, deleting the config file fixes this issue, however when disabling Blighted elites in the config, the same bug occurs
Files
No clue if I did this right so I'm sorry in advance
log.txt log from C:/Users/[User Name]/AppData/Roaming/r2modmanPlus-local
LogOutput.log log from C:/Users/[User Name]/AppData/Roaming/r2modmanPlus-local/RiskOfRain2/profiles/[Profile Name]/BepInEx
aQVSopXdpi Code for mod list
Mod list.txt Mod list in notepad form if you don't want to download the profile
Edits
Edit 1: Added "damage" to opening line
Edit 2: Added screenshot of mod list showing only LostInTransit and dependencies enabled (game has no resolution where text is legible as well as the mod list on screen)
Edit 3: Added "Partial fix" section
Edit 4: Forgot to add the log and mod list, so I added both r2modman's log and BepInEx's log (both files are different) and added an export code and notepad file listing mods. Also added headers to make this dissertation a little more organized.
Edit 5: Added a note regarding the item in my inventory. Also changed the name of this section because "Change" and "Edit" mean the exact same thing.
Edit 6: Removed "Volatile" as Volatile setting disabled doesn't affect this. Also added a note explaining what causes the issue, as well as changed the initial note to side note.