Port to Swup 4 - Githubissues

swup / astro

Astro integration for swup 🚀

94 stars 2 forks source link

Port to Swup 4 #1

Closed daun closed 1 year ago

daun commented 1 year ago

Description

Update swup and plugins for v4
Drive-by: Add support for form submissions
Drive-by: Add support for parallel animations
Tested in Astro playground

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)
[ ] ~~All tests are passing (npm run test)~~
[ ] ~~New or updated tests are included~~
[x] The documentation was updated as required

hirasso commented 1 year ago

Should the types also be added to "exports" here, or are these all astro integration standards?

{
  "exports": {
    ".": "./dist/index.js",
    "./client": "./dist/client.js",
    "./client/*": "./dist/client/*.js",
    "./idle": "./dist/idle.js",
    "./package.json": "./package.json"
  },
}

daun commented 1 year ago

Should the types also be added to "exports" here, or are these all astro integration standards?

The general structure of the repo is that of official Astro integrations. But you're right, they probably should be exported as well. I'll make an issue to keep track of it.