swup / docs

Official swup documentation 📘
https://swup.js.org/getting-started
12 stars 35 forks source link

feat : use navigation plugin #105

Closed hirasso closed 1 year ago

hirasso commented 1 year ago

Description

Sooo. This PR escalated quite a bit 😅

Checks

netlify[bot] commented 1 year ago

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
Latest commit fe6c950e8e354f476281d88f6b4aa4ac2ead9757
Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/644a1f3c51d5d0000816f548
Deploy Preview https://deploy-preview-105--splendorous-kataifi-9ae281.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

daun commented 1 year ago

Fantastic :) Can we get the navigation plugin to open external links in a new tab? Currently, they seem to open in the same tab.

hirasso commented 1 year ago

Fantastic :) Can we get the navigation plugin to open external links in a new tab? Currently, they seem to open in the same tab.

Not out of the box. I'll look into it.

gmrchk commented 1 year ago

The mobile menu button seems broken, or is that just me?

hirasso commented 1 year ago

External links now opening in a new tab. Everywhere, not only in the menu 💅

hirasso commented 1 year ago

The mobile menu button seems broken, or is that just me?

Still works for me. But this would be the next optimization target, anyways I'd say :)

hirasso commented 1 year ago

Guys, this is so much fun. 11ty rocks!!!

hirasso commented 1 year ago

I guess I rushed a bit with adding the target="_blank" to all external links. I think I got a bit greedy with all the nice things eleventy offers 😅

I reverted everything external-link-related and re-implemented it as a progressive enhancement:

daun commented 1 year ago

I can't keep up with any of this 🤠 But it looks good to me!