swup / docs

Official swup documentation 📘
https://swup.js.org/getting-started
12 stars 36 forks source link

Showcase Page #186

Closed daun closed 3 months ago

daun commented 3 months ago

Description

Questions

Screenshot

Screenshot 2024-04-05 at 15 02 25

Checks

Additional information

Closes #184

netlify[bot] commented 3 months ago

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
Latest commit edea7322c8f4b3e258ad419909f31e77fb2400f0
Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/6610390a3d4e3200080baad2
Deploy Preview https://deploy-preview-186--splendorous-kataifi-9ae281.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hirasso commented 3 months ago

This looks beautiful!

How to call this: Showcase vs. Gallery vs. ?

I prefer Showcase. Gallery could be a functionality or swup or something

Where to put this in the nav? What's more interesting/useful to new users: demos or showcase?

I think it's perfect after the demos page

Do you already want a code review? I've already found a little typo with my last name ;)

daun commented 3 months ago

@hirasso Haha, shit, fixed the typo 🤠 And sure, if you're okay with the position in the nav, this is ready to be merged! We can keep collecting more examples later.

daun commented 3 months ago

Added a link to the submission readme.

hirasso commented 3 months ago

Added a link to the submission readme.

Currently that leads to a 404: https://github.com/swup/docs/blob/master/src/showcase/README.md

How do you imagine the submission process to go?

daun commented 3 months ago

@hirasso That's the final link after merging. While the PR is not merged, this one should lead to the same file:

https://github.com/swup/docs/blob/2e4294da53db26ddf30ff91a7f0b97edacca9581/src/showcase/README.md

daun commented 3 months ago

I've opted for putting it in the repo as opposed to just the docs to also get the attention of people source-diving :)

daun commented 3 months ago

@hirasso Updated with both suggestions. Please reapprove :)

hirasso commented 3 months ago

Just out of curiosity: Why did you still add the tag names to the selectors? a.class-name, li.class-name, ...

As a precaution to prevent possible overwrites from other styles?

daun commented 3 months ago

@hirasso I hate that too 🤠 But it's to increase specificity and override the default styles here. Un-nesting unfortunatley ruined the whole layout, adding back selectors fixed it nicely.

hirasso commented 3 months ago

It's a mess. Sorry :)