search

swup / docs

Official swup documentation 📘
https://swup.js.org/getting-started
12 stars 35 forks source link

feat: add section about issues with navigation to known issues #198

Closed hirasso closed 1 month ago

hirasso commented 1 month ago

Description

Direct link to preview deploy: https://deploy-preview-198--splendorous-kataifi-9ae281.netlify.app/getting-started/common-issues/#the-browser-performs-a-hard-visit-instead-of-a-swup-transition

Checks

netlify[bot] commented 1 month ago

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
Latest commit b2dc2ecbad72c25edad14cb51f8923191253c23d
Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/66ab7fd9a3443d0008d115ce
Deploy Preview https://deploy-preview-198--splendorous-kataifi-9ae281.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

daun commented 1 month ago

Great idea.

I would slightly rephrase the first bullet point — maybe "One of the containers is missing in the old or new page" is a bit more to the point than "mismatch" in my opinion. And should we add a note about installing the debug plugin to this bullet point as well? We could add a check there that warns about missing containers directly on load to prevent the error being swallowed by the hard page load. Happy to do that :)

hirasso commented 1 month ago

I never found the debug plugin to be the most useful TBH... but it wouldn't hurt to add a reference to it somewhere along the lines here I guess. Would you like to push directly to this PR? :)

daun commented 1 month ago

Alright, added a note about debug plugin, and a link to the devtools manual on the preserve-log option. Couldn't help it and simplified the wording here and there, feel free to revert if it distorts what you were trying to say.

Ready to go from my end :)

hirasso commented 1 month ago

🤝

daun commented 1 month ago

@hirasso I've added some more checks to the debug plugin to make it actually useful for newcomers.