Closed hirasso closed 7 months ago
My reasoning behind putting this on hold is that if I would have have had it on my fingertips before implementing this feature, I very likely would have missed the opportunity to think about the root issue I had. I'm still very much open to merge this the day we find an issue that is absolutely not fixable with the declarative API.
Sounds like a plan!
Actually, I just realized that too many things have changed in master and merging this would be a nightmare. I'll close this PR, we can always get back to it and extract the functionality back into master should we end up needing it sometime in the future.
On Hold
The issue was solvable by making sure that all fragments in a rule must match an element in the
document
. I'll keep this PR around and in sync withmaster
, should we need it sometime.Description
Adds a new property
if
to fragment rules, to only run rules if they match the callback:Or:
The real use case I'm using it for:
Checks
master
branchnpm run lint
)