Prevent Escape key presses on `<dialog>` fragments

swup / fragment-plugin

A swup plugin for dynamically replacing containers based on rules 🧩

https://swup-fragment-plugin.netlify.app

MIT License

15 stars 1 forks source link

Prevent Escape key presses on `<dialog>` fragments #62

Closed hirasso closed 10 months ago

hirasso commented 10 months ago

Related: #61

Description

Prevent Escape key presses on <dialog> fragments.

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)
[x] All tests are passing (npm run test)

daun commented 10 months ago

I have to admit I'm really not up to speed on the dialog stuff, so I prefer deferring to your judgement here :) If this is how all dialogs work as you're saying, it really shouldn't have any negative effects. And I agree that without this, it's kind of broken for the fragment use case.