feat: `rule.if` - Githubissues

hirasso commented 3 months ago

Description

It's time! For a current project I finally need rule.if. This is a rewrite of #47

added a new test
also manually tested the behavior in the project where I need it

Questions

naming: rule.if or rule.predicate? Currently, the property is if, the type if Predicate.
currently, rule.if will prevent a rule from being matched if it returns a falsy value (if (!this.if)...). Would it make sense to make that more strict? (if (this.if === false))?

Drive-By

cleaned up some code comments

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)
[x] All tests are passing (npm run test)
[x] New or updated tests are included
[x] The documentation was updated as required

github-actions[bot] commented 3 months ago

Playwright test results

passed 12 passed

Details

stats 12 tests across 1 suite

commit d973886

daun commented 3 months ago

Yeah, been looking forward to this 🥯 Calling it if makes more sense to me than predicate, in terms of readability. Loose boolean matching is probably also fine -- as long as ommitting the if function is equivalent to () => true.

hirasso commented 3 months ago

as long as ommitting the if function is equivalent to () => true

Yes, it is. ok great!

swup / fragment-plugin

feat: `rule.if` #77

Playwright test results

Details