Port to TypeScript - Githubissues

swup / scroll-plugin

A swup plugin for smooth scrolling 🏄‍♂️

https://swup.js.org/plugins/scroll-plugin

MIT License

3 stars 8 forks source link

Port to TypeScript #61

Closed hirasso closed 1 year ago

hirasso commented 1 year ago

Description

Port to TypeScript

Notes

scrl has a PR waiting for TypeScript. Until then, I'm using any for it.
npm run format still alerts [warn] jsxBracketSameLine is deprecated. I don't know why, thought there was an update implemented for this some time ago.
I decided to bump both the peerDependency as well as requires for swup to ^4.2.0. That way, visit.to.hash should actually be available in doScrollingBetweenPages.

Drive-By

Bug-fix: maybeResetScrollPositions was always resetting the scroll position. Should now correctly respect options.shouldResetScrollPosition (tested manually in playground).

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)
[x] All tests are passing (npm run test) Tested this by running the swup plugin tests with a compiled umd-version of this branch

daun commented 1 year ago

Looks good, let's just confirm that the switch to Math.round doesn't remove support for 10px style offset.