Emulate scroll :target - Githubissues

swup / scroll-plugin

A swup plugin for smooth scrolling 🏄‍♂️

https://swup.js.org/plugins/scroll-plugin

MIT License

3 stars 8 forks source link

Emulate scroll :target #69

Closed daun closed 1 year ago

daun commented 1 year ago

Description

Emulate native :target selector that stops working when updating URLs via History API
Introduce a setting markScrollTarget to mark targets with a data-swup-scroll-target attribute
Waiting on PR #772 on the core to work properly

Checks

[x] The PR is submitted to the master branch
[x] The code was linted before pushing (npm run lint)
[x] The documentation was updated as required

Additional information

Closes #53

hirasso commented 1 year ago

Did you test the exact native behavior of :target? If I recall correctly, the selector is not being applied if clicking on an anchor link that scrolls on the same page. It's only applied if visiting a page with a hash anchor directly, doesn't it?

I'm only on mobile so I can't properly test it right now 😩😉

daun commented 1 year ago

@hirasso As far as I know, :target gets updated whenever the URL changes, which also happens when jumping between anchors on the same page.