swuxyj / DeepHash-pytorch

Implementation of Some Deep Hash Algorithms, Including DPSH、DSH、DHN、HashNet、DSDH、DTSH、DFH、GreedyHash、CSQ.
MIT License
495 stars 116 forks source link

A small mistake about the implementation of "Unsupervised_BiHalf.py" #20

Closed liyunqianggyn closed 3 years ago

liyunqianggyn commented 3 years ago

Hey,

I am one author of paper "Unsupervised_BiHalf", and thanks a lot for adding our paper in this nice Implementation.

I notice a small mistake in implementing the model at test time in line 77-79: 1 During training, we train to align continuous distribution p(u) with the half-half distribution of +1 and −1(bi-half layer). This allows us at test time to simply use the "sign function" as a deterministic function for quantization. image

Could you help us change bi-half to sign at test time, thanks a lot!

swuxyj commented 3 years ago

Yes, I got the MAP 0.593, which is amazing. I am sorry for my carelessness.

liyunqianggyn commented 3 years ago

Thanks :)