Closed yaegassy closed 3 years ago
As a side note, this problem was confirmed in esbonio v0.5.1
.
This is not a bug in the v0.6.0 release.
:thinking:....
I can't say for sure but my guess is that the language server is not correctly encoding the filepaths when on Windows. I've opened #167 which might fix this issue - is there any chance you could download and install this version of the language server in a test environment and see if it does?
Side note: would you mind sharing the esbonio portion of your vim config? It would come in handy for #45 :smile:
I tried this pull request. https://github.com/swyddfa/esbonio/pull/167
The "diagnostics" worked correctly.
Awesome, I'll look to get #167 merged soon
Side note: would you mind sharing the esbonio portion of your vim config? It would come in handy for #45 😄
I created a vim-plugin(coc.nvim extension) the coc-esbonio
using esbonio's language server and VSCode extension as reference.
I also use another LSP client plugin called vim-lsp
.
:CocInstall coc-esbonio
settings(.vimrc):
'cmd' should be python where "esbonio" is installed '--cache-dir' can be set to any directory.
augroup LspEsbonio
autocmd!
autocmd User lsp_setup call lsp#register_server({
\ 'name': 'esbonio',
\ 'cmd': {server_info->[
\ expand('~/.local/src/esbonio/venv/bin/python'), '-m', 'esbonio',
\ '--cache-dir', '/tmp/esbonio/sphinx',
\ '--log-level', 'error'
\ ]},
\ 'allowlist': ['rst'],
\ 'workspace_config': {
\ 'esbonio': {
\ 'sphinx': {
\ 'confDir': "",
\ 'srcDir': "",
\ },
\ },
\ }
\ })
augroup END
@alcarney As a separate report, the esbonio.sphinx.confDir
and esbonio.sphinx.srcDir
settings have been added since "v0.6.0".
If this setting itself "does not exist", esbonio will fail to start.
Error:
Exception occurred in notification: "{'code': -32602, 'message': 'None: None', 'data': "{'traceback': []}"}"
For the VSCode extension, there is of course a setting in package.json
, which is passed as the default value, but for other LSP clients, the setting can be omitted.
I thought it would be good to adjust the default value to ""
if the setting itself is not passed on the language server side.
I created a vim-plugin(coc.nvim extension) the coc-esbonio using esbonio's language server and VSCode extension as reference.
That's awesome :smile:, and thank you for the config examples
@alcarney As a separate report, the esbonio.sphinx.confDir and esbonio.sphinx.srcDir settings have been added since "v0.6.0". If this setting itself "does not exist", esbonio will fail to start.
Ah good catch... I think I handled the case where confDir
or srcDir
were missing but not the case where the parent esbonio.sphinx
namespace is not available. I've opened #171 to track this.
@alcarney When is the next release scheduled to reflect this fix?
There's a few more fixes I'd like to get in first, but I'm hoping to get something out within the next week or so :crossed_fingers:
@yaegassy v0.6.1 of the language server is now out! :smiley:
I'm using esbonio's language server from Vim (coc.nvim), "coc.nvim" is a VSCode-like plug-in for Vim.
I usually use it on macOS, but when I try it on Windows, I can't get the "diagnostics".
"Completion", etc. are working fine.
This is the output of my Vim (coc.nvim) channel log on Windows.
This may not be a problem for VSCode extensions, but perhaps it needs to be adjusted for use outside of VSCode. (regex, path, etc...)
(I'm sorry if this is a problem specific to my Windows environment.)