Esbonio server start command should quote the python path

swyddfa / esbonio

A language server for working with Sphinx projects.

https://docs.esbon.io/

130 stars 21 forks source link

Esbonio server start command should quote the python path #541

Closed DiegoF90 closed 10 months ago

DiegoF90 commented 1 year ago

Starting the server when using a default python path with spaces fails. For example:

Server start command: C:\Program Files (x86)\python\env_local\Scripts\python.exe -m esbonio

Fails with:

'C:\Program' is not recognized as an internal or external command, operable program or batch file.

alcarney commented 1 year ago

Unfortunately, I’m struggling to reproduce this on my Windows install…

Can I confirm that you are using the Esbonio VSCode extension and if so what version? I ask since the reStructuredText extension also has support for esbonio and judging by the comments in https://github.com/vscode-restructuredtext/vscode-restructuredtext/issues/406 it may or may not still be affected by this issue.

alcarney commented 10 months ago

Closing as this is most likely a duplicate of #658 and not something that can be fixed from this repo. Feel free to reopen if this is in fact an issue with the Esbonio extension!