swyddfa / esbonio

A language server for working with Sphinx projects.
https://docs.esbon.io/
130 stars 21 forks source link

python.exe with space in path #658

Closed neil-benn closed 10 months ago

neil-benn commented 10 months ago

Hello,

I've pulled in esbonio as part of a module related to restructured text and the issue is that because the python is in 'program files' th python executbale path is not escaped with speechmarks. Therefore I get:

[Log - 11:27:52 AM] Server start command: C:\Program Files\Python311\python.exe -m esbonio
[Log - 11:27:52 AM] LanguageClientOptions: {"documentSelector":[{"scheme":"file","language":"restructuredtext"},{"scheme":"file","language":"python"}],"initializationOptions":{"sphinx":{"srcDir":null,"confDir":"","forceFullBuild":true,"numJobs":1,"buildDir":null},"server":{"logLevel":"error","logFilter": ],"hideSphinxOutput":false,"enableScrollSync":true}},"outputChannel":{"name":"Esbonio Language Server"}}
[Log - 11:27:52 AM] Starting Language Server
'C:\Program' is not recognized as an internal or external command, operable program or batch file.

Is this something esbonio related or is it how vs code or the restructured text extension is calling esbonio to start it?

Regards,

Neil

alcarney commented 10 months ago

I believe this is the issue you are experiencing.

It is down to how the restructured text extension is starting the language server and so unfortunately isn't something that can be fixed from this repo.

neil-benn commented 10 months ago

Hello,

Oh well thanks, the replies on that link we're pretty negative so I'll just uninstall the extension. Thanks for finding that, the fix is obviously easy but the will to fix isn't there.

Never mind.

Cheers,

Neil

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Alex Carney @.> Sent: Wednesday, October 11, 2023 10:38:51 PM To: swyddfa/esbonio @.> Cc: Benn, Neil @.>; Author @.> Subject: Re: [swyddfa/esbonio] python.exe with space in path (Issue #658)

I believe thishttps://github.com/vscode-restructuredtext/vscode-restructuredtext/issues/406 is the issue you are experiencing.

It is down to how the restructured text extension is starting the language server and so unfortunately isn't something that can be fixed from this repo.

— Reply to this email directly, view it on GitHubhttps://github.com/swyddfa/esbonio/issues/658#issuecomment-1758584206, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY2NXTU6I5DLID3FUHED4TX64GWXANCNFSM6AAAAAA53YO3PE. You are receiving this because you authored the thread.Message ID: @.***>

alcarney commented 10 months ago

You might want to consider trying the Esbonio extension which is part of this repo - however it will only provide the esbonio language server and not the other tools like doc8 or rstcheck

neil-benn commented 10 months ago

Hello,

Thanks it's the rst stuff I need mostly but I'll see what esbonio on it's own does.

Cheers,

Neil

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: Alex Carney @.> Sent: Wednesday, October 11, 2023 11:15:45 PM To: swyddfa/esbonio @.> Cc: Benn, Neil @.>; Author @.> Subject: Re: [swyddfa/esbonio] python.exe with space in path (Issue #658)

You might want to consider trying the Esboniohttps://marketplace.visualstudio.com/items?itemName=swyddfa.esbonio extension which is part of this repo - however it will only provide the esbonio language server and not the other tools like doc8 or rstcheck

— Reply to this email directly, view it on GitHubhttps://github.com/swyddfa/esbonio/issues/658#issuecomment-1758622502, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY2NXTGCFTUFOXZKFFLF3LX64LBDANCNFSM6AAAAAA53YO3PE. You are receiving this because you authored the thread.Message ID: @.***>

alcarney commented 10 months ago

No worries! :)