swyddfa / esbonio

A language server for working with Sphinx projects.
https://docs.esbon.io/
121 stars 21 forks source link

Default keybindings for opening previews in markdown files? #780

Open alcarney opened 2 months ago

alcarney commented 2 months ago

Expected behavior

It should be easy to open esbonio's preview from within a markdown file, either through keyboard shortcut or editor menu button

Actual behavior

The when clauses in the extension's package.json need to be updated to consider markdown files.

Log output

No response

(Optional) Settings from conf.py

No response

alcarney commented 2 months ago

Quoting myself from the above commit

Whereas the reStructuredText part of the extension could copy the patterns for previews established by VSCode's markdown support, doing so for markdown files would (surprise, surprise!) create conflicts.

So, the toolbar button and command names have been "re-branded" to make them distinct from the built-in markdown ones. The reStructuredText part of the extension keeps its existing keybindings (for now?) and no keybindings have been set for the markdown side.

Open for suggestions as to what a good default keybinding could be :)