Server does not end progress when the build fails

swyddfa / esbonio

A language server for working with Sphinx projects.

https://docs.esbon.io/

121 stars 21 forks source link

Server does not end progress when the build fails #802

Open alcarney opened 2 months ago

alcarney commented 2 months ago

Expected behavior

After a build had failed VSCode was still showing the window/workDoneProgress spinner, even though no build was in progress.

Actual behavior

The server should ensure the progress is marked as complete, even when there's an error

Log output

No response

(Optional) Settings from conf.py

No response

alcarney commented 6 days ago

Not sure if it's necessarily build failures, or if it's many builds triggered in succession? After actually using the pre-release a bit more recently, I often see the progress spinner when it's not actually building...