fix: don't update URL infinitely on blog index based on search params

swyxio / swyxkit

An opinionated blog starter for SvelteKit + Tailwind + Netlify. Refreshed for SvelteKit 1.0!

https://swyxkit.netlify.app/

MIT License

675 stars 88 forks source link

fix: don't update URL infinitely on blog index based on search params #119

Closed martypenner closed 2 years ago

martypenner commented 2 years ago

When cloning this repo according to the instructions and wiring it up to my simple list of posts, I noticed the cursor flickering when I navigated to the blog page and the browser would freeze. Turns out an infinite redirect was happening. This PR addresses that by only navigating when the search params have actually changed.

swyxio commented 2 years ago

well that's embarrassing. thank you!

martypenner commented 2 years ago

well that's embarrassing. thank you!

You should see the code I write on a regular basis ;). Glad I could contribute!