sxb1261 / macosx-nosleep-extension

Automatically exported from code.google.com/p/macosx-nosleep-extension
0 stars 0 forks source link

Black and white menu icon is still in color #57

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
!!! IF YOU'RE GOING TO CREATE A DEFECT REPORT (not FR), PLEASE, ATTACH
AN OUTPUT FROM "sudo dmesg".

!!! Describe your problem in details - it is impossible to reproduce
something like: "it turns on randomly"

P.S.: Actually I'm not bad:) - CAPS is only for visibility. And please,
remove non-relevant text from the tracker.

What steps will reproduce the problem?
1. Right click the nosleep icon in the menu bar
2. Select "Preferences"
3. Check the "Use black and white menu bar icons" checkbox
4. Quit system preferences.
5. Left click on the nosleep icon in the menu bar

What is the expected output? What do you see instead?

Regardless of whether the "Use black and white menu bar icons" option is 
selected, the icon still turns blue when you left click and have it active.

Clicking on the icon toggles the "Never sleep on Battery" option on and off.  
When the icon is blue, the "Never sleep on Battery" option is on.  When the 
icon is black, the "Never sleep on Battery" option is off.

I would expect that the "Use black and white menu bar icons" option makes it so 
that the nosleep icon is not blue when active.  I assumed that some other black 
and white icon would take its place.  

What version of the product are you using? On what operating system?

This is NoSleep version 1.3.1, on a Mid-2010 13" MacBook Pro running OS X 
10.7.4 

Original issue reported on code.google.com by eric.s....@gmail.com on 6 Oct 2012 at 11:32

Attachments:

GoogleCodeExporter commented 8 years ago
Ah, I just realized what's going on--the checkbox seems to do the OPPOSITE of 
what it says.  When I have the "Use black and white menu bar icons" option 
checked, it uses color icons.  When the option is unchecked, it uses black and 
white icons.

Inverted logic.  Should be a simple fix!

Original comment by eric.s....@gmail.com on 6 Oct 2012 at 11:34

GoogleCodeExporter commented 8 years ago
Here's a screenshot with the preferences dialog open, showing the issue.  The 
checkbox is not checked, and the icon is black and white.

Original comment by eric.s....@gmail.com on 6 Oct 2012 at 11:36

Attachments:

GoogleCodeExporter commented 8 years ago
From here logic looks correct (black and white icon is used when checkbox is 
checked), but you have to restart NoSleep utility for changes to take effect.

Original comment by mdou...@gmail.com on 8 Oct 2012 at 5:20