search

sxiao3 / jsmpp

Automatically exported from code.google.com/p/jsmpp
Apache License 2.0
0 stars 0 forks source link

NumberingPlanIndicator values incorrect #90

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The NumeringPlanIndicator byte values look wrong. Detected during jUnit testing 
of my app, which uses jSMPP.

The current values are:
0   UNKNOWN
1   ISDN
2   DATA
3   TELEX
4   LAND_MOBILE
8   NATIONAL
9   PRIVATE
16  ERMES
20  INTERNET
24  WAP

But according to the SMPP 3.4 spec, chapter 5.2.6, they should be:
0   UNKNOWN
1   ISDN
3   DATA
4   TELEX
6   LAND_MOBILE
8   NATIONAL
9   PRIVATE
10  ERMES
14  INTERNET
18  WAP

Hence they are incorrect for DATA, TELEX, LAND_MOBILE, ERMES, INTERNET and WAP.

Using jSMPP 2.1.

Original issue reported on code.google.com by eivind.s...@gmail.com on 3 Dec 2010 at 9:13

GoogleCodeExporter commented 8 years ago 
Is there any fix planned for this problem?

Original comment by ashishma...@gmail.com on 16 Mar 2011 at 2:53

GoogleCodeExporter commented 8 years ago 
Looks like JSMPP bug fixing pretty much stopped after the 2.1.0 release in 
August 2009.

Original comment by eivind.s...@gmail.com on 17 Mar 2011 at 10:38

GoogleCodeExporter commented 8 years ago 
I'll check this soon. Pretty busy. Sorry.

Original comment by uuda...@gmail.com on 17 Mar 2011 at 4:09

GoogleCodeExporter commented 8 years ago 
I believe this already been fixed on the latest trunk

Original comment by uuda...@gmail.com on 20 Mar 2011 at 4:14