search

sxrsdk / sxrsdk

Apache License 2.0
16 stars 21 forks source link

fix for Quest #146

Closed thomasflynn closed 5 years ago

thomasflynn commented 5 years ago 
remove explicitly setting the default framebuffer width and height and
allow it to be queried from the Oculus SDK.

the code in ovr_configuration_helper.cpp checks to see if the width or
height are -1 (which is what they are initialized to) and if so, uses
the value provided by the Oculus SDK.  By setting the width and height
in OvrActivityDelegate.java, that check is bypassed.

this appears to be one reason why apps on Quest look so funky right now.
Eyebuffer on Quest are rectangular, not square.  The other appears to be related to needing 
an asymmetric view frustum.  I'm still working on that issue.

SXR-DCO-1.0-Signed-off-by: Tom Flynn tom.flynn@samsung.com

liaxim commented 5 years ago

@sushantojal Since you added these two lines, any comments?

sushantojal commented 5 years ago

We can go ahead with this PR. I think I made this change for running the vulkan tests so that the width/height matched correctly with the golden master.