search

sxs-collaboration / gwsurrogate

An easy to use interface to gravitational wave surrogate models
Other
25 stars 22 forks source link

Error in readme / example usage #54

Open GarethCabournDavies opened 2 months ago

GarethCabournDavies commented 2 months ago

Using the example https://github.com/sxs-collaboration/gwsurrogate/tree/master?tab=readme-ov-file#download-surrogate-data-and-load-it

I found that once the surrogate has been evaluated, dyn is returned as None, this is at odds with the comment statement dyn stands for dynamics, do dyn.keys() to see contents

Looking into help(sur) for the NRSur7dq4 surrogate, it says This is None for nonprecessing models, so I think this is just a case of updating that comment

GarethCabournDavies commented 2 months ago

This was found in https://github.com/openjournals/joss-reviews/issues/7073