search

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
160 stars 189 forks source link

Documentation should include instructions for running IWYU on hpp files #1089

Open markscheel opened 6 years ago

markscheel commented 6 years ago

Feature request:

Documentation only says how to run IWYU on .cpp files, and when I do this, IWYU does not check the included .hpp files in some (all?) cases. I verified this by putting random #includes in one of my hpp files and IWYU didn't care. When running on Travis, IWYU similarly ignores my .hpp files.

It would be nice to have the ability to run IWYU on .hpp files. If this is difficult to do, then perhaps this issue shouldn't be a high priority.

Component:

nilsdeppe commented 3 years ago

@kidder @markscheel since we don't use IWYU anymore, sholud we close this?

markscheel commented 3 years ago

Do we have any plans to bring back IWYU? I have no idea wither the new versions are any better than the version we had been using, but it seems that IWYU is still being updated.

fmahebert commented 3 years ago

I recently played around a little with IWYU for clang-10, and it was hardly any better than the IWYU for clang-5 that we were previously using. As in, still lots of false recommendations, esp associated with forward decls and template-heavy types.