sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

162 stars 191 forks source link

Consistent Notation for Temporal Index #1223

Open hrueter opened 5 years ago

hrueter commented 5 years ago

Bug reports:

Expected behavior:

The character denoting a temporal index is consistent.

Current behavior:

0 as well as t is used.

Environment:

For example in: ComputeGhQuantities.hpp ComputeSpacetimeQuantities.hpp

Proposed solution

Use 0 everywhere for temporal indices. The index t could be misinterpreted as a contraction with the timelike normal vector t^a. If there are no objections to this proposal I will fix it this way in the next days.

nilsdeppe commented 5 years ago

@markscheel @kidder @wthrowe @fmahebert opinions?

I'm fine using 0 as the time index.

wthrowe commented 5 years ago

Fine with me.

fmahebert commented 5 years ago

Fine with me, as well

kidder commented 5 years ago

Using 0 is fine with me @markscheel do you have an opinion?