Random failure in CylindricalFlatEndcap

[nilsdeppe]

Bug reports:

2021-11-04T08:25:55.5682116Z /__w/spectre/spectre/tests/Unit/Domain/CoordinateMaps/Test_CylindricalFlatEndcap.cpp:72
2021-11-04T08:25:55.5682998Z ...............................................................................
2021-11-04T08:25:55.5683309Z 
2021-11-04T08:25:55.5684032Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:147: FAILED:
2021-11-04T08:25:55.5684918Z   CHECK( a == appx(b) )
2021-11-04T08:25:55.5685386Z with expansion:
2021-11-04T08:25:55.5685814Z   0.193448278980767
2021-11-04T08:25:55.5686191Z   ==
2021-11-04T08:25:55.5686680Z   Approx( 0.19344827898072622 )
2021-11-04T08:25:55.5687102Z with messages:
2021-11-04T08:25:55.5687640Z   CylindricalFlatEndcap
2021-11-04T08:25:55.5688300Z   Seed is: 2861186933 from /__w/spectre/spectre/tests/Unit/Domain/
2021-11-04T08:25:55.5689145Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2021-11-04T08:25:55.5689833Z   radius_two := 0.78073528575685824
2021-11-04T08:25:55.5690370Z   radius_one := 0.13789003849262108
2021-11-04T08:25:55.5690768Z   center_two := { 0.75782336372903925, 0.16425636355752449, 0.0194105409180596
2021-11-04T08:25:55.5691136Z   }
2021-11-04T08:25:55.5691678Z   center_one := { -0.15040791752458016, 0.75463567703556689, -2.
2021-11-04T08:25:55.5692036Z   86522640139276374 }
2021-11-04T08:25:55.5692570Z   proj_center := { 0.91813615862223696, -0.11865935855649168, -0.
2021-11-04T08:25:55.5692942Z   63243294017466167 }
2021-11-04T08:25:55.5693430Z   Seed is: 2912522045 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2021-11-04T08:25:55.5694113Z   CoordinateMaps/TestMapHelpers.hpp:548
2021-11-04T08:25:55.5694631Z   height := 0.64782416157007683
2021-11-04T08:25:55.5694983Z   phi := 0.81511299236307733
2021-11-04T08:25:55.5695312Z   radius := 0.28208250588953093
2021-11-04T08:25:55.5695680Z   Test inverse map
2021-11-04T08:25:55.5696083Z   test_point := { 0.193448278980767, 0.20530051994161291, 1.0 }
2021-11-04T08:25:55.5696740Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2021-11-04T08:25:55.5697698Z   hpp:396: test_point == expected_test_point.value()
2021-11-04T08:25:55.5698247Z   a := { 0.193448278980767, 0.20530051994161291, 1.0 }
2021-11-04T08:25:55.5698663Z   b := { 0.19344827898072622, 0.20530051994164547, 1.00000000000000044 }
2021-11-04T08:25:55.5698947Z 
2021-11-04T08:25:55.5699614Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:147: FAILED:
2021-11-04T08:25:55.5700309Z   CHECK( a == appx(b) )
2021-11-04T08:25:55.5700909Z with expansion:
2021-11-04T08:25:55.5701358Z   0.20530051994161291
2021-11-04T08:25:55.5701848Z   ==
2021-11-04T08:25:55.5702255Z   Approx( 0.20530051994164547 )
2021-11-04T08:25:55.5702692Z with messages:
2021-11-04T08:25:55.5703266Z   CylindricalFlatEndcap
2021-11-04T08:25:55.5703984Z   Seed is: 2861186933 from /__w/spectre/spectre/tests/Unit/Domain/
2021-11-04T08:25:55.5704882Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2021-11-04T08:25:55.5705630Z   radius_two := 0.78073528575685824
2021-11-04T08:25:55.5706095Z   radius_one := 0.13789003849262108
2021-11-04T08:25:55.5747125Z   center_two := { 0.75782336372903925, 0.16425636355752449, 0.0194105409180596
2021-11-04T08:25:55.5747600Z   }
2021-11-04T08:25:55.5748540Z   center_one := { -0.15040791752458016, 0.75463567703556689, -2.
2021-11-04T08:25:55.5749003Z   86522640139276374 }
2021-11-04T08:25:55.5749664Z   proj_center := { 0.91813615862223696, -0.11865935855649168, -0.
2021-11-04T08:25:55.5750141Z   63243294017466167 }
2021-11-04T08:25:55.5750761Z   Seed is: 2912522045 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2021-11-04T08:25:55.5751593Z   CoordinateMaps/TestMapHelpers.hpp:548
2021-11-04T08:25:55.5752232Z   height := 0.64782416157007683
2021-11-04T08:25:55.5752669Z   phi := 0.81511299236307733
2021-11-04T08:25:55.5753081Z   radius := 0.28208250588953093
2021-11-04T08:25:55.5753536Z   Test inverse map
2021-11-04T08:25:55.5754029Z   test_point := { 0.193448278980767, 0.20530051994161291, 1.0 }
2021-11-04T08:25:55.5754850Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2021-11-04T08:25:55.5755762Z   hpp:396: test_point == expected_test_point.value()
2021-11-04T08:25:55.5756354Z   a := { 0.193448278980767, 0.20530051994161291, 1.0 }
2021-11-04T08:25:55.5756818Z   b := { 0.19344827898072622, 0.20530051994164547, 1.00000000000000044 }
2021-11-04T08:25:55.5757127Z 
2021-11-04T08:25:55.5758147Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:147: FAILED:
2021-11-04T08:25:55.5758926Z   CHECK( a == appx(b) )
2021-11-04T08:25:55.5759575Z with expansion:
2021-11-04T08:25:55.5760109Z   0.0 == Approx( -0.00000000000002276 )
2021-11-04T08:25:55.5760492Z with messages:
2021-11-04T08:25:55.5760961Z   CylindricalFlatEndcap
2021-11-04T08:25:55.5761535Z   Seed is: 2861186933 from /__w/spectre/spectre/tests/Unit/Domain/
2021-11-04T08:25:55.5762271Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2021-11-04T08:25:55.5763048Z   radius_two := 0.78073528575685824
2021-11-04T08:25:55.5763484Z   radius_one := 0.13789003849262108
2021-11-04T08:25:55.5763940Z   center_two := { 0.75782336372903925, 0.16425636355752449, 0.0194105409180596
2021-11-04T08:25:55.5764350Z   }
2021-11-04T08:25:55.5764951Z   center_one := { -0.15040791752458016, 0.75463567703556689, -2.
2021-11-04T08:25:55.5765358Z   86522640139276374 }
2021-11-04T08:25:55.5765972Z   proj_center := { 0.91813615862223696, -0.11865935855649168, -0.
2021-11-04T08:25:55.5766403Z   63243294017466167 }
2021-11-04T08:25:55.5766958Z   Seed is: 2912522045 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2021-11-04T08:25:55.5767730Z   CoordinateMaps/TestMapHelpers.hpp:548
2021-11-04T08:25:55.5768320Z   height := 0.64782416157007683
2021-11-04T08:25:55.5768724Z   phi := 0.81511299236307733
2021-11-04T08:25:55.5769104Z   radius := 0.28208250588953093
2021-11-04T08:25:55.5769523Z   Test inverse map
2021-11-04T08:25:55.5769955Z   test_point := { 0.0, 0.0, 1.0 }
2021-11-04T08:25:55.5770685Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2021-11-04T08:25:55.5771600Z   hpp:396: test_point == expected_test_point.value()
2021-11-04T08:25:55.5772054Z   a := { 0.0, 0.0, 1.0 }
2021-11-04T08:25:55.5772547Z   b := { 0.0000000000000131, -0.00000000000002276, 1.0 }

[markscheel]

Note that most likely CylindricalFlatEndcap will eventually be removed because I expect the newer cylindrical maps (like the one in #3325) to be more applicable to the domains that we want.

[nilsdeppe]

okay, if it's getting superceded then it's not clear it's worth the effort fixing this failure. It's the only one I've seen in months :)

[markscheel]

Ok. If this failure becomes a bigger problem then I can do something about it.

[wthrowe]

Is there a timeline for removing this class? It's been over a year.

2022-11-16T21:46:09.5018739Z Unit.Domain.CoordinateMaps.CylindricalFlatEndcap
2022-11-16T21:46:09.5019222Z -------------------------------------------------------------------------------
2022-11-16T21:46:09.5019641Z /__w/spectre/spectre/tests/Unit/Domain/CoordinateMaps/Test_CylindricalFlatEndcap.cpp:71
2022-11-16T21:46:09.5020009Z ...............................................................................
2022-11-16T21:46:09.5020171Z 
2022-11-16T21:46:09.5020361Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:151: FAILED:
2022-11-16T21:46:09.5020669Z   CHECK( a == appx(b) )
2022-11-16T21:46:09.5020895Z with expansion:
2022-11-16T21:46:09.5021131Z   0.0 == Approx( 0.00000000000002222 )
2022-11-16T21:46:09.5021350Z with messages:
2022-11-16T21:46:09.5021581Z   CylindricalFlatEndcap
2022-11-16T21:46:09.5021885Z   Seed is: 2264742339 from /__w/spectre/spectre/tests/Unit/Domain/
2022-11-16T21:46:09.5022225Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2022-11-16T21:46:09.5022518Z   radius_two := 0.60310537399861774
2022-11-16T21:46:09.5022746Z   radius_one := 0.13576512799291254
2022-11-16T21:46:09.5023100Z   center_two := { 0.80726495179999747, -0.73145663196154642, 0.
2022-11-16T21:46:09.5023341Z   31596310716223086 }
2022-11-16T21:46:09.5023680Z   center_one := { 0.10841865577445653, -1.11614425619032565, -2.
2022-11-16T21:46:09.5023921Z   55175397747489985 }
2022-11-16T21:46:09.5024244Z   proj_center := { 0.72626777875772541, -0.39549010386040617, -0.
2022-11-16T21:46:09.5024486Z   12561855834152319 }
2022-11-16T21:46:09.5024770Z   Seed is: 1890936612 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2022-11-16T21:46:09.5025098Z   CoordinateMaps/TestMapHelpers.hpp:552
2022-11-16T21:46:09.5025365Z   height := 0.75987073645556458
2022-11-16T21:46:09.5025581Z   phi := 1.94209430410558048
2022-11-16T21:46:09.5025904Z   radius := 0.71537220369120202
2022-11-16T21:46:09.5026131Z   Test inverse map
2022-11-16T21:46:09.5026431Z   test_point := { -0.0, 0.0, 1.0 }
2022-11-16T21:46:09.5026761Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2022-11-16T21:46:09.5027121Z   hpp:399: test_point == expected_test_point.value()
2022-11-16T21:46:09.5027420Z   a := { -0.0, 0.0, 1.0 }
2022-11-16T21:46:09.5027772Z   b := { -0.00000000000000082, 0.00000000000002222, 0.99999999999999989 }
2022-11-16T21:46:09.5027935Z 
2022-11-16T21:46:09.5028120Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:151: FAILED:
2022-11-16T21:46:09.5028430Z   CHECK( a == appx(b) )
2022-11-16T21:46:09.5028655Z with expansion:
2022-11-16T21:46:09.5028872Z   0.0 == Approx( 0.00000000000002222 )
2022-11-16T21:46:09.5029100Z with messages:
2022-11-16T21:46:09.5029333Z   CylindricalFlatEndcap
2022-11-16T21:46:09.5029626Z   Seed is: 2264742339 from /__w/spectre/spectre/tests/Unit/Domain/
2022-11-16T21:46:09.5029968Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2022-11-16T21:46:09.5030248Z   radius_two := 0.60310537399861774
2022-11-16T21:46:09.5030484Z   radius_one := 0.13576512799291254
2022-11-16T21:46:09.5030836Z   center_two := { 0.80726495179999747, -0.73145663196154642, 0.
2022-11-16T21:46:09.5031074Z   31596310716223086 }
2022-11-16T21:46:09.5031480Z   center_one := { 0.10841865577445653, -1.11614425619032565, -2.
2022-11-16T21:46:09.5031726Z   55175397747489985 }
2022-11-16T21:46:09.5032056Z   proj_center := { 0.72626777875772541, -0.39549010386040617, -0.
2022-11-16T21:46:09.5032299Z   12561855834152319 }
2022-11-16T21:46:09.5032584Z   Seed is: 1890936612 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2022-11-16T21:46:09.5032912Z   CoordinateMaps/TestMapHelpers.hpp:552
2022-11-16T21:46:09.5033175Z   height := 0.75987073645556458
2022-11-16T21:46:09.5033387Z   phi := 1.94209430410558048
2022-11-16T21:46:09.5033613Z   radius := 0.71537220369120202
2022-11-16T21:46:09.5033842Z   Test inverse map
2022-11-16T21:46:09.5034138Z   test_point := { -0.0, 0.0, 1.0 }
2022-11-16T21:46:09.5034467Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2022-11-16T21:46:09.5034815Z   hpp:399: test_point == expected_test_point.value()
2022-11-16T21:46:09.5035122Z   a := { -0.0, 0.0, 1.0 }
2022-11-16T21:46:09.5035473Z   b := { -0.00000000000000082, 0.00000000000002222, 0.99999999999999989 }

[wthrowe]

2023-07-09T17:27:35.6325676Z -------------------------------------------------------------------------------
2023-07-09T17:27:35.6326049Z Unit.Domain.CoordinateMaps.CylindricalFlatEndcap
2023-07-09T17:27:35.6326479Z -------------------------------------------------------------------------------
2023-07-09T17:27:35.6326878Z /__w/spectre/spectre/tests/Unit/Domain/CoordinateMaps/Test_CylindricalFlatEndcap.cpp:71
2023-07-09T17:27:35.6327218Z ...............................................................................
2023-07-09T17:27:35.6327371Z 
2023-07-09T17:27:35.6327547Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:154: FAILED:
2023-07-09T17:27:35.6327821Z   CHECK( a == appx(b) )
2023-07-09T17:27:35.6328023Z with expansion:
2023-07-09T17:27:35.6328294Z   0.0 == Approx( -0.00000000000002711 )
2023-07-09T17:27:35.6328505Z with messages:
2023-07-09T17:27:35.6328720Z   CylindricalFlatEndcap
2023-07-09T17:27:35.6328988Z   Seed is: 2203833193 from /__w/spectre/spectre/tests/Unit/Domain/
2023-07-09T17:27:35.6329307Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2023-07-09T17:27:35.6329582Z   radius_two := 0.67890018398154461
2023-07-09T17:27:35.6329802Z   radius_one := 0.10895931761780206
2023-07-09T17:27:35.6330123Z   center_two := { 0.82569786009554869, -0.85122474883641197, -0.
2023-07-09T17:27:35.6330338Z   07661538825539393 }
2023-07-09T17:27:35.6330632Z   center_one := { 0.46459640799030688, -0.57236143171228915, -3.
2023-07-09T17:27:35.6330843Z   64122535770699107 }
2023-07-09T17:27:35.6331146Z   proj_center := { 1.26611261054921687, -0.7840253840818181, -0.
2023-07-09T17:27:35.6331366Z   38010309112816393 }
2023-07-09T17:27:35.6331618Z   Seed is: 3877480281 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2023-07-09T17:27:35.6331920Z   CoordinateMaps/TestMapHelpers.hpp:553
2023-07-09T17:27:35.6332168Z   height := 0.99810744045730604
2023-07-09T17:27:35.6332378Z   phi := 5.33956219747467209
2023-07-09T17:27:35.6332685Z   radius := 0.1621056696777386
2023-07-09T17:27:35.6332888Z   Test inverse map
2023-07-09T17:27:35.6333150Z   test_point := { 0.0, -0.0, 1.0 }
2023-07-09T17:27:35.6333462Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2023-07-09T17:27:35.6333803Z   hpp:399: test_point == expected_test_point.value()
2023-07-09T17:27:35.6334087Z   a := { 0.0, -0.0, 1.0 }
2023-07-09T17:27:35.6334405Z   b := { -0.00000000000002711, 0.00000000000000645, 1.00000000000000044 }
2023-07-09T17:27:35.6334556Z 
2023-07-09T17:27:35.6334721Z /__w/spectre/spectre/tests/Unit/Framework/TestingFramework.hpp:154: FAILED:
2023-07-09T17:27:35.6335095Z   CHECK( a == appx(b) )
2023-07-09T17:27:35.6335304Z with expansion:
2023-07-09T17:27:35.6335569Z   0.0 == Approx( -0.00000000000002711 )
2023-07-09T17:27:35.6335781Z with messages:
2023-07-09T17:27:35.6335981Z   CylindricalFlatEndcap
2023-07-09T17:27:35.6336258Z   Seed is: 2203833193 from /__w/spectre/spectre/tests/Unit/Domain/
2023-07-09T17:27:35.6336581Z   CoordinateMaps/Test_CylindricalFlatEndcap.cpp:20
2023-07-09T17:27:35.6336853Z   radius_two := 0.67890018398154461
2023-07-09T17:27:35.6337069Z   radius_one := 0.10895931761780206
2023-07-09T17:27:35.6337386Z   center_two := { 0.82569786009554869, -0.85122474883641197, -0.
2023-07-09T17:27:35.6337596Z   07661538825539393 }
2023-07-09T17:27:35.6337898Z   center_one := { 0.46459640799030688, -0.57236143171228915, -3.
2023-07-09T17:27:35.6338112Z   64122535770699107 }
2023-07-09T17:27:35.6338411Z   proj_center := { 1.26611261054921687, -0.7840253840818181, -0.
2023-07-09T17:27:35.6338636Z   38010309112816393 }
2023-07-09T17:27:35.6338889Z   Seed is: 3877480281 from /__w/spectre/spectre/tests/Unit/Helpers/Domain/
2023-07-09T17:27:35.6339342Z   CoordinateMaps/TestMapHelpers.hpp:553
2023-07-09T17:27:35.6339588Z   height := 0.99810744045730604
2023-07-09T17:27:35.6339798Z   phi := 5.33956219747467209
2023-07-09T17:27:35.6340009Z   radius := 0.1621056696777386
2023-07-09T17:27:35.6340210Z   Test inverse map
2023-07-09T17:27:35.6340477Z   test_point := { 0.0, -0.0, 1.0 }
2023-07-09T17:27:35.6340788Z   /__w/spectre/spectre/tests/Unit/Helpers/Domain/CoordinateMaps/TestMapHelpers.
2023-07-09T17:27:35.6341125Z   hpp:399: test_point == expected_test_point.value()
2023-07-09T17:27:35.6341411Z   a := { 0.0, -0.0, 1.0 }
2023-07-09T17:27:35.6341716Z   b := { -0.00000000000002711, 0.00000000000000645, 1.00000000000000044 }
2023-07-09T17:27:35.6341868Z 
2023-07-09T17:27:35.6342050Z 0.022 s: Unit.Domain.CoordinateMaps.CylindricalFlatEndcap
2023-07-09T17:27:35.6347170Z ===============================================================================
2023-07-09T17:27:35.6347448Z test cases:    1 |    0 passed | 1 failed
2023-07-09T17:27:35.6347707Z assertions: 4355 | 4353 passed | 2 failed