sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
155 stars 187 forks source link

Cluster environments should treat dependencies as system-installed #3699

Open nilsvu opened 2 years ago

nilsvu commented 2 years ago

Bug reports:

Some build configurations on clusters emit numerous warnings from headers in our dependencies. We should set up the environments so they treat the dependencies as system-installed to avoid the warnings. This mainly involves replacing CPATH with C_INCLUDE_PATH or CPLUS_INCLUDE_PATH in the environment files.

More information:

Note that (1) CMake treats include directories from imported targets as "system" by default and (2) even when the CPATH is set the directories should be treated as "system" as of https://gitlab.kitware.com/cmake/cmake/-/merge_requests/3395.

wthrowe commented 2 years ago

To aid others making the change: I believe that our C-compatible dependencies are

and the C++-only ones are