sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
154 stars 187 forks source link

EvolveGhCce doesn't compile #6012

Open wthrowe opened 1 month ago

wthrowe commented 1 month ago
/home/wthrowe/spectre/src/Evolution/Executables/GeneralizedHarmonic/EvolveGhAndCharacteristic.cpp:25:7: error: no matching constructor for initialization of 'const std::vector<void (*)()> &'
   25 |       {&domain::creators::register_derived_with_charm,
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   26 |        &domain::creators::time_dependence::register_derived_with_charm,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   27 |        &domain::FunctionsOfTime::register_derived_with_charm,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   28 |        &gh::BoundaryCorrections::register_derived_with_charm,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   29 |        &gh::ConstraintDamping::register_derived_with_charm,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   30 |        &Cce::register_initialize_j_with_charm<
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |            metavariables::evolve_ccm, metavariables::cce_boundary_component>,
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |        &register_derived_classes_with_charm<Cce::WorldtubeDataManager>,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   33 |        &register_derived_classes_with_charm<intrp::SpanInterpolator>,
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   34 |        &register_factory_classes_with_charm<metavariables>},
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
$ git describe
v2024.05.11-32-gb580941efc
knelli2 commented 1 month ago

This hasn't compiled for a while because we don't build it on CI because it runs out of memory.

wthrowe commented 1 month ago

If no one is going to maintain it, can we remove it? Trying to update code that doesn't compile is annoying.

knelli2 commented 1 month ago

The reason that we kept this was because this is supposed to be the stepping stone to CCM. However, this has been thrown way down on my priority list for now, and I don't think @Sizheng-Ma has been actively working on this either, but it is still something we want to do eventually.

If we don't want people to be able to build it, but we want to keep the source code, we can just comment out the CMake code so it's not visible to our build system. Or we add a commit that removes it, then revert that commit later.

wthrowe commented 1 month ago

The build system isn't the problem, since you have to explicitly request it. What do I do if I need to change the code, but I can't even test if my change compiles?

Sizheng-Ma commented 1 month ago

I've been looking at SpEC CCM on my side. So this executable is outdated and no one is using it. I'm happy to remove it and revert that commit later.

wthrowe commented 1 month ago

Let's do that. I won't try to update it with my current changes to avoid conflicts.

knelli2 commented 1 month ago

@wthrowe Do you just want to remove the exec in #6013?

wthrowe commented 1 month ago

I would rather not delay that PR.