sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
159 stars 189 forks source link

Split time-stepper-history cleaning from update #6019

Closed wthrowe closed 4 months ago

wthrowe commented 4 months ago

Reduces the amount of data we need to store in checkpoints, mostly in LTS.

Proposed changes

Upgrade instructions

Evolution executables now need to include the Actions::CleanHistory action after each variable update. See the modifications to the executables in this PR for suggested exact changes.

Code review checklist

Further comments

nilsdeppe commented 4 months ago

Hmm, do you understand the clang-tidy error? Tthis looks like it's telling us to change the STL?

wthrowe commented 4 months ago

I think it's just complaining about charm stuff, but the charm class happens to be stored in a std::optional so the traces go through there.

I haven't examined the charm code in detail, but it looks like it's doing reference counting, which can cause false positives for this sort of automated analysis, so it's probably fine.

nilsdeppe commented 4 months ago

Sounds good! Merging now :)