This allows to get the horizon area, mass, spin, etc from BBH initial data just by calling a Python function.
Upgrade instructions
The FindHorizons3D executable was removed. You can find horizons in 3D volume data in Python like this:
from spectre.Pipelines.Bbh.FindHorizon import find_horizon
from spectre.SphericalHarmonics import Strahlkorper
horizon, quantities = find_horizon(
h5_files, subfile_name, obs_id, obs_time,
initial_guess=Strahlkorper(l_max, m_max, radius, center)
)
mass = quantities["ChristodoulouMass"]
spin = quantities["DimensionlessSpinMagnitude"]
Code review checklist
[ ] The code is documented and the documentation renders correctly. Run
make doc to generate the documentation locally into BUILD_DIR/docs/html.
Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the
code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or
new feature if appropriate.
Proposed changes
This allows to get the horizon area, mass, spin, etc from BBH initial data just by calling a Python function.
Upgrade instructions
The
FindHorizons3Dexecutable was removed. You can find horizons in 3D volume data in Python like this:Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html. Then openindex.html.bugfixornew featureif appropriate.Further comments