sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
154 stars 187 forks source link

More minor code for nodegroup elements #6027

Closed nilsdeppe closed 1 month ago

nilsdeppe commented 1 month ago

Proposed changes

Upgrade instructions

Code review checklist

Further comments

nilsdeppe commented 1 month ago

I've rebased and pushed fixups. I added a decent number of words for the return type being size_t since that is important. I'll need to clean this class up a bit after everything is working, mostly just the documentation. I also added value_type as a type alias since this is actually what the STL uses. It's not used right now, though.

nilsdeppe commented 1 month ago

Done! Thanks!