sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Add DgElementArrayMember #6042

Closed nilsdeppe closed 1 month ago

nilsdeppe commented 1 month ago

Proposed changes

Upgrade instructions

Code review checklist

Further comments

nilsdeppe commented 1 month ago
  1. added nolint for one. I don't know what to do about the other. The code seems to compile with clang so I don't know why clang-tidy is having issues.
  2. Probably in the long run. I didn't mostly because we'll also need to test switching to a group instead of nodegroup to get it working with Kokkos, so just a lot of imminent changes that I don't know what they will require.
  3. I've rebased and squashed. Thanks for the review!