sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Add fixed object radius and increase run speed #6049

Closed vtommasini closed 1 month ago

vtommasini commented 1 month ago

Proposed changes

Changed the OuterRadius of ObjectA and ObjectB from 6.683 to 6.0, as we found this to be the working limit so as to avoid having the constraints blow up. We have also changed all 5 of the UpdateFraction in ControlSystems from 0.03 to 0.3 to considerable increase the speed of the simulation. A full merger takes ~2 days.

Code review checklist

nilsvu commented 1 month ago

@vtommasini please squash your commits into one

nilsvu commented 1 month ago

Test failure is unrelated

github-actions[bot] commented 1 month ago

@vtommasini looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:

  1. Edit the Metadata.yaml file in the repository.
  2. Add an entry to the list in Authors.Contributors with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.
  3. Commit the change on a new branch and open a pull request with the change.

Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.