Closed vtommasini closed 1 month ago
@vtommasini please squash your commits into one
Test failure is unrelated
@vtommasini looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:
Metadata.yaml
file in the repository.Authors.Contributors
with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.
Proposed changes
Changed the OuterRadius of ObjectA and ObjectB from 6.683 to 6.0, as we found this to be the working limit so as to avoid having the constraints blow up. We have also changed all 5 of the UpdateFraction in ControlSystems from 0.03 to 0.3 to considerable increase the speed of the simulation. A full merger takes ~2 days.
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.