Closed nilsdeppe closed 1 month ago
@wthrowe did you want to look at this too? Edit: on vacation
I believe @wthrowe is on vacation until Thursday and we would like this merged for the ETK workshop, which is this week. Kyle's presenting on Thursday. Given the time pressure, I'd like to retroactively address any comments @wthrowe may have.
Yes thank you for the speedy reviews :)
I'll submit a separate PR with the Ubuntu 18.04 support. I have that mostly working now for automated deployment...
Proposed changes
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments