sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Add support for Charm 7.0.1, switch container to it, and add Charm++ license+copyright #6050

Closed nilsdeppe closed 1 month ago

nilsdeppe commented 1 month ago

Proposed changes

Upgrade instructions

Code review checklist

Further comments

nilsvu commented 1 month ago

@wthrowe did you want to look at this too? Edit: on vacation

nilsdeppe commented 1 month ago

I believe @wthrowe is on vacation until Thursday and we would like this merged for the ETK workshop, which is this week. Kyle's presenting on Thursday. Given the time pressure, I'd like to retroactively address any comments @wthrowe may have.

knelli2 commented 1 month ago

Yes thank you for the speedy reviews :)

nilsdeppe commented 1 month ago

I'll submit a separate PR with the Ubuntu 18.04 support. I have that mostly working now for automated deployment...