Switch to using 4 cores in CI since GitHub supports that now

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

153 stars 185 forks source link

Switch to using 4 cores in CI since GitHub supports that now #6052

Closed nilsdeppe closed 1 month ago

nilsdeppe commented 1 month ago

Proposed changes

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

nilsdeppe commented 1 month ago

Done! I squashed and rebased. I also added a commit that increases the timeout of the MeanValue test since that timed out on 2 different GCC builds.

knelli2 commented 1 month ago

Lots of timeouts. I noticed on my local machine that if I used all my cores to run tests, I got a lot of timeouts. Especially for the executables since they need 2 cores to run (1 charm + 1 worker). Maybe for executable tests we only run with 2 cores?

nilsdeppe commented 1 month ago

Yea, I'll switch that back to 2 and add a comment :)

nilsdeppe commented 1 month ago

Okay, done!