Closed moble closed 4 days ago
Thanks, Mike!
@moble the very fine time steps stem from the error based time stepping that CCE utilizes; this is why I added the t_interpolate
option (https://github.com/moble/scri/blob/62df4db6099bd3d11035e2a6325d2524e6281168/scri/SpEC/file_io/__init__.py#L485) to create_abd_from_h5
because, for practical purposes, we will always want to use the time array of the worldtube from the Cauchy evolution as t_interpolate
. (At least this is what we decided on a while back in the vacuum call for the catalog).
Thanks for going through this @moble! I can definitely implement these suggestions. Yeah I think unfortunately the legend stuff is important since our H5 IO looks for it. I also think @keefemitman's solution for the time stepping is the way to go, and we can address outputting every N steps in the future.
I've gone through the CCE tutorial, and it looks pretty good. I think it should be very helpful to users in the workshop. I have a few fairly minor comments and questions about it, though.
ExampleInput.yaml
that @nilsdeppe pointed me to, my output seemed to have excessively fine time steps. This was also something I saw in data that Nils had run himself. Throughout inspiral the timestep is ~4e-2, and drops as low as ~5e-3 after merger; compare these to 0.5 and 0.05, respectively, for a typical extrapolated waveform. It really makes BMS correction extraordinarily slow. The tutorial suggestsScriOutputDensity
is important, but that's already just 1. Is there some other default we could tweak to lighten the load a bit?scri
, there's an option to correct by the Christodoulou mass. Where is this number found?scri
tutorial should probably point directly to the relevant section, because there's a lot on that page, and it's not clear where to find the part about adjust the BMS frame.