Closed isaaclegred closed 2 days ago
@nilsvu whenever you get a chance!
I think everything should be done except removing the "flat" things. I'll do that in a separate commit after squashing all of this because I plan on keeping it around on a branch just in case it becomes useful for checking that the executable is working .
@nilsvu I renamed everything to BnsInitialData
in order to make it more general. Also fixed up comments.
Proposed changes
This PR adds the system for generating BNS Irrotational Initial data. To do this, an elliptic system is introduced to solve for the velocity potential using the framework of Baumgarte + Shapiro Ch. 15. The background consists of a matter profile which is not yet implemented (as it is contained in the initial data).
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments